Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup views::as_rvalue tests #3089

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Cleanup views::as_rvalue tests #3089

merged 1 commit into from
Sep 13, 2022

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Sep 8, 2022 •
edited
Loading

Changes:

  • After merging Unwrappable iter/sent pairs! #3024 test_equal function became unnecessary - we can replace it with ranges::equal,
  • Fixed two comments, that mentioned as_const_view instead of as_rvalue_view.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner September 8, 2022 11:56
@StephanTLavavej StephanTLavavej added the test Related to test code label Sep 8, 2022
@StephanTLavavej
Copy link
Member

Thanks, great catches! 😻

@StephanTLavavej StephanTLavavej added this to Final Review in Code Reviews Sep 8, 2022
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Sep 12, 2022
@StephanTLavavej StephanTLavavej self-assigned this Sep 12, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 6e72b6a into microsoft:main Sep 13, 2022
Code Reviews automation moved this from Ready To Merge to Done Sep 13, 2022
@StephanTLavavej
Copy link
Member

Thanks for noticing and cleaning up these test issues! 🦅 😸 🎉

@JMazurkiewicz JMazurkiewicz deleted the cleanup_as_rvalue_tests branch September 13, 2022 22:19
CaseyCarter pushed a commit to CaseyCarter/STL that referenced this pull request Oct 6, 2022
@JMazurkiewicz @CaseyCarter
Cleanup views::as_rvalue tests (microsoft#3089)
a7e660d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
test Related to test code
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JMazurkiewicz @StephanTLavavej @strega-nil-ms