Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ranges::is_permutation's helper lambdas #3113

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Fix ranges::is_permutation's helper lambdas #3113

merged 2 commits into from
Sep 22, 2022

Conversation

JMazurkiewicz
Copy link
Contributor

Fixes #2888.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner September 19, 2022 14:09
strega-nil-ms
strega-nil-ms approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StephanTLavavej StephanTLavavej added bug Something isn't working ranges C++20/23 ranges labels Sep 20, 2022
@StephanTLavavej StephanTLavavej added this to Final Review in Code Reviews Sep 20, 2022
CaseyCarter
CaseyCarter approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except for an extraneous semicolon, which I'll cleanup.

tests/std/tests/P0896R4_ranges_alg_is_permutation/test.cpp Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Sep 20, 2022
@StephanTLavavej
Copy link
Member

✅ No modules impact here (I am double-checking in-flight PRs to make sure we don't miss any needed exports).

@StephanTLavavej StephanTLavavej self-assigned this Sep 22, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej changed the title Fix ranges::is_permutations's helper lambdas Fix ranges::is_permutation's helper lambdas Sep 22, 2022
@StephanTLavavej StephanTLavavej merged commit b79bbbc into microsoft:main Sep 22, 2022
Code Reviews automation moved this from Ready To Merge to Done Sep 22, 2022
@StephanTLavavej
Copy link
Member

compiler for Thanks 😹 errors! ✅ these fixing 🎉

@JMazurkiewicz JMazurkiewicz deleted the fix_is_permutation branch September 22, 2022 21:50
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request Oct 6, 2022
@JMazurkiewicz @CaseyCarter
Fix ranges::is_permutation's helper lambdas (microsoft#3113)
787eb80 
Co-authored-by: Casey Carter <cartec69@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working ranges C++20/23 ranges
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<algorithm>: ranges::is_permutation's helper lambda does not specify return type
4 participants
@JMazurkiewicz @StephanTLavavej @CaseyCarter @strega-nil-ms