Constexprize bind_front and bind_back tests
#3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strega-nil-ms
approved these changes
Sep 21, 2022
StephanTLavavej
approved these changes
Sep 22, 2022
|
Thanks, this looks great! 😻 I pushed some nitpicky changes, and a minor expansion of test coverage (ensuring we invoke both binders with ✅ No modules impact - test-only changes. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for finding this long-ago-filed issue and improving the test coverage here! ✅ 😻 🎉 |
CaseyCarter
pushed a commit
to CaseyCarter/STL
that referenced
this pull request
Oct 6, 2022
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #968.
This PR constexprizes already existing tests and adds extra PMF test for
bind_back.