Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3823 Unnecessary precondition for is_aggregate (workaround) #3231

Merged
merged 3 commits into from Nov 18, 2022
Merged

Implement LWG-3823 Unnecessary precondition for is_aggregate (workaround) #3231

merged 3 commits into from Nov 18, 2022

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #3229.

I suppose this is a temporary workaround. It would become unnecessary when compiler changes land.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner November 15, 2022 14:51
@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Nov 15, 2022
@CaseyCarter CaseyCarter added this to Initial Review in Code Reviews via automation Nov 15, 2022
CaseyCarter
CaseyCarter approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor non-functional changes which I'll push.

stl/inc/type_traits Outdated Show resolved Hide resolved
stl/inc/type_traits Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter moved this from Initial Review to Final Review in Code Reviews Nov 15, 2022
@StephanTLavavej StephanTLavavej self-assigned this Nov 16, 2022
@StephanTLavavej StephanTLavavej removed their assignment Nov 17, 2022
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Nov 17, 2022
@StephanTLavavej StephanTLavavej self-assigned this Nov 18, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 2127d8b into microsoft:main Nov 18, 2022
Code Reviews automation moved this from Ready To Merge to Done Nov 18, 2022
@StephanTLavavej
Copy link
Member

static_assert(is_awesome_v<decltype(frederick-vs-ja)>); // 😻🎉🚀

@frederick-vs-ja frederick-vs-ja deleted the lwg-3823 branch November 19, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3823 Unnecessary precondition for is_aggregate
3 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter