Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stl.natvis std::optional<*> #3243

Merged
merged 4 commits into from Dec 6, 2022
Merged

fix stl.natvis std::optional<*> #3243

merged 4 commits into from Dec 6, 2022

Conversation

strega-nil-ms
Copy link
Contributor

optional<*> originally used <Intrinsic>s for _Has_value and _Value; however, apparently VS doesn't like doing custom visualizers for <Intrinsic> calls.

Fixes VSO-1631025 / DevCom-10155697

@strega-nil
fix stl.natvis std::optional<*>
4100330 
`optional<*>` originally used `<Intrinsic>`s for `_Has_value` and `_Value`;
however, apparently VS doesn't like doing custom visualizers for
`<Intrinsic>` calls.

Fixes VSO-1631025 / DevCom-10155697
@strega-nil-ms strega-nil-ms requested a review from a team as a code owner November 22, 2022 22:45
@strega-nil-ms strega-nil-ms added this to Initial Review in Code Reviews via automation Nov 22, 2022
@strega-nil-ms strega-nil-ms added the visualizer How the VS debugger displays STL types label Nov 22, 2022
@strega-nil-ms strega-nil-ms moved this from Initial Review to Final Review in Code Reviews Nov 22, 2022
cpplearner
cpplearner reviewed Nov 22, 2022
View reviewed changes
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
strega-nil-ms and others added 2 commits November 23, 2022 10:08
@strega-nil-ms @cpplearner
Update stl/debugger/STL.natvis
3b3fe0f 
Co-authored-by: S. B. Tam <cpplearner@outlook.com>
@strega-nil
remove extra whitespace
0f76aec
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Nov 29, 2022
@StephanTLavavej StephanTLavavej self-assigned this Dec 5, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit aeed392 into microsoft:main Dec 6, 2022
Code Reviews automation moved this from Ready To Merge to Done Dec 6, 2022
@StephanTLavavej
Copy link
Member

Thanks for fixing this visualizer! 🪐 🔭 👁️

@strega-nil-ms strega-nil-ms deleted the fix-optional-visualizer branch December 19, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpplearner cpplearner cpplearner left review comments

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
visualizer How the VS debugger displays STL types
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@strega-nil-ms @StephanTLavavej @CaseyCarter @cpplearner @strega-nil