fix and rename _Within_limits, add tests
#3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
requested changes
Nov 30, 2022
tests/std/tests/Dev11_0316853_find_memchr_optimization/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/Dev11_0316853_find_memchr_optimization/test.cpp
Outdated
Show resolved
Hide resolved
CaseyCarter
previously requested changes
Nov 30, 2022
StephanTLavavej
requested changes
Nov 30, 2022
|
I removed the optimization change; I'll open an issue for it. |
strega-nil-ms
changed the title
_Within_limits, add tests
StephanTLavavej
approved these changes
Dec 5, 2022
StephanTLavavej
dismissed
CaseyCarter’s stale review
Requested changes have been made
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
strega-nil-ms
pushed a commit
to strega-nil/stl
that referenced
this pull request
Dec 6, 2022
CaseyCarter
approved these changes
Dec 6, 2022
| } else { | ||
| constexpr auto max_vt = numeric_limits<ValueType>::max(); | ||
| if constexpr (ElementType{-1} == max_vt) { | ||
| // ugly conversions :( |
There was a problem hiding this comment.
Non-inclusive conversion shaming! (No change requested.)
|
Thanks for fixing this runtime correctness regression! 🛠️ 😻 ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3244, I believe.