Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add transition comment to ios_base::hexfloat #3300

Merged
merged 2 commits into from Jan 11, 2023
Merged

add transition comment to ios_base::hexfloat #3300

merged 2 commits into from Jan 11, 2023

Conversation

strega-nil-ms
Copy link
Contributor

See issue #3296

@strega-nil-ms strega-nil-ms requested a review from a team as a code owner December 20, 2022 00:03
@strega-nil-ms strega-nil-ms added the enhancement Something can be improved label Dec 20, 2022
@strega-nil-ms strega-nil-ms added this to Initial Review in Code Reviews via automation Dec 20, 2022
@strega-nil-ms strega-nil-ms moved this from Initial Review to Final Review in Code Reviews Dec 20, 2022
AlexGuteniev
AlexGuteniev suggested changes Dec 20, 2022
View reviewed changes
stl/inc/xiosbase Outdated Show resolved Hide resolved
stl/inc/xiosbase Outdated Show resolved Hide resolved
Code Reviews automation moved this from Final Review to Work In Progress Dec 20, 2022
@strega-nil-ms @AlexGuteniev
Apply suggestions from code review
80ccd0f 
Co-authored-by: Alex Guteniev <gutenev@gmail.com>
@strega-nil-ms
Copy link
Contributor Author

Thanks Alex!

@StephanTLavavej StephanTLavavej added documentation Related to documentation or comments and removed enhancement Something can be improved labels Jan 4, 2023
@StephanTLavavej StephanTLavavej moved this from Work In Progress to Final Review in Code Reviews Jan 4, 2023
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Jan 4, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jan 11, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 7cbb0da into microsoft:main Jan 11, 2023
Code Reviews automation moved this from Ready To Merge to Done Jan 11, 2023
@StephanTLavavej
Copy link
Member

Thanks for properly recording how the STL was hexed here, so we can remember to lift the curse in the future! 👻 🪄 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexGuteniev AlexGuteniev AlexGuteniev requested changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
documentation Related to documentation or comments
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@strega-nil-ms @StephanTLavavej @AlexGuteniev @strega-nil