Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG-3848: slide_view missing base accessor #3410

Merged
merged 3 commits into from Feb 14, 2023
Merged

LWG-3848: slide_view missing base accessor #3410

merged 3 commits into from Feb 14, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Feb 12, 2023 •
edited by StephanTLavavej

This PR adds base accessor to ranges::slide_view implemented in #2670.

Fixes #3409.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner February 12, 2023 00:01
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue ranges C++20/23 ranges labels Feb 12, 2023
@StephanTLavavej StephanTLavavej added this to Initial Review in Code Reviews via automation Feb 12, 2023
@StephanTLavavej StephanTLavavej mentioned this pull request Feb 12, 2023
Closed
61 tasks
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Feb 12, 2023
@StephanTLavavej
Copy link
Member

Thanks! I pushed a tiny commit to remove an unnecessary check (copy-pasted?).

@JMazurkiewicz
Copy link
Contributor Author

JMazurkiewicz commented Feb 12, 2023 •
edited

Thanks! I pushed a tiny commit to remove an unnecessary check (copy-pasted?).

Yes, it was copy-pasted from P2442R1_views_chunk/test.cpp - and it looks like this check is also uneccessary there.

@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Feb 12, 2023
@JMazurkiewicz
Copy link
Contributor Author

FYI I've pushed two extra changes:

  • // strengthend comment for base and size members tests,
  • Correct exception check for slide_view::size.

@StephanTLavavej StephanTLavavej self-assigned this Feb 13, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit aee02b5 into microsoft:main Feb 14, 2023
Code Reviews automation moved this from Ready To Merge to Done Feb 14, 2023
@StephanTLavavej
Copy link
Member

Thanks for helping the STL slide towards increased conformance! 🎚️ 📈 😻

@JMazurkiewicz JMazurkiewicz deleted the lwg3848 branch February 14, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperWig SuperWig SuperWig left review comments

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3848 adjacent_view, adjacent_transform_view, and slide_view missing base accessor
5 participants
@JMazurkiewicz @StephanTLavavej @CaseyCarter @SuperWig @strega-nil-ms