Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG-3872: basic_const_iterator should have custom iter_move #3470

Merged
merged 1 commit into from Feb 23, 2023
Merged

LWG-3872: basic_const_iterator should have custom iter_move #3470

merged 1 commit into from Feb 23, 2023
+23 −2

Conversation

JMazurkiewicz
Copy link
Contributor

Closes #3429.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner February 15, 2023 13:20
@github-actions github-actions bot added this to Initial Review in Code Reviews Feb 15, 2023
@StephanTLavavej StephanTLavavej mentioned this pull request Feb 15, 2023
Closed
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Feb 15, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Feb 15, 2023
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Feb 17, 2023
@StephanTLavavej StephanTLavavej self-assigned this Feb 22, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit df915b6 into microsoft:main Feb 23, 2023
Code Reviews automation moved this from Ready To Merge to Done Feb 23, 2023
@StephanTLavavej
Copy link
Member

Thanks for implementing and testing this LWG issue resolution! So much conformance! 😹 📈 🚀

@JMazurkiewicz JMazurkiewicz deleted the lwg3872 branch February 23, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3872 basic_const_iterator should have custom iter_move
4 participants
@JMazurkiewicz @StephanTLavavej @CaseyCarter @strega-nil-ms