Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWG-3862: basic_const_iterator's common_type specialization is underconstrained #3471

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

Closes #3428. Also improves test coverage for common_type.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner February 15, 2023 14:33
@github-actions github-actions bot added this to Initial Review in Code Reviews Feb 15, 2023
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Feb 15, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Feb 15, 2023
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Feb 17, 2023
@StephanTLavavej StephanTLavavej self-assigned this Feb 22, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit f91eba5 into microsoft:main Feb 23, 2023
Code Reviews automation moved this from Ready To Merge to Done Feb 23, 2023
@StephanTLavavej
Copy link
Member

Thanks for constraining this specialization so it can't escape and devour local bird populations! 🐈 😋 🐦

@JMazurkiewicz JMazurkiewicz deleted the lwg3862 branch February 23, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LWG Library Working Group issue
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

LWG-3862 basic_const_iterator's common_type specialization is underconstrained
3 participants