Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2164R9: views::enumerate #3472

Merged
merged 15 commits into from Feb 26, 2023
Merged

P2164R9: views::enumerate #3472

merged 15 commits into from Feb 26, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

Closes #3438.

Drive-by: simplify noexcept specification of slide_view::_Iterator constructor.

@github-actions github-actions bot added this to Work In Progress in Code Reviews Feb 15, 2023
@JMazurkiewicz JMazurkiewicz changed the title views::enumerate P2164R9: views::enumerate Feb 15, 2023
@StephanTLavavej StephanTLavavej added cxx23 C++23 feature ranges C++20/23 ranges labels Feb 15, 2023
@JMazurkiewicz JMazurkiewicz marked this pull request as ready for review February 15, 2023 21:49
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner February 15, 2023 21:49
@JMazurkiewicz

This comment was marked as outdated.

@github-actions github-actions bot moved this from Work In Progress to Initial Review in Code Reviews Feb 15, 2023
@StephanTLavavej
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

# Copyright (c) Microsoft Corporation.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

RUNALL_INCLUDE ..\strict_concepts_latest_matrix.lst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change requested, note for other reviewers: Confirmed that strict is necessary.

stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
tests/std/tests/P2164R9_views_enumerate/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P2164R9_views_enumerate/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P2164R9_views_enumerate/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P2164R9_views_enumerate/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P2164R9_views_enumerate/test.cpp Outdated Show resolved Hide resolved
Code Reviews automation moved this from Initial Review to Work In Progress Feb 16, 2023
@StephanTLavavej

This comment was marked as resolved.

@JMazurkiewicz

This comment was marked as outdated.

@github-actions github-actions bot moved this from Work In Progress to Initial Review in Code Reviews Feb 17, 2023
@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Feb 17, 2023
@StephanTLavavej StephanTLavavej self-assigned this Feb 24, 2023
@StephanTLavavej
Copy link
Member

I am a greedy kitty who is speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll push a fix for my comments

stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Feb 26, 2023
@StephanTLavavej
Copy link
Member

I've pushed a merge with main to fix a trivial adjacent-add conflict in tests/std/test.lst.

@StephanTLavavej StephanTLavavej merged commit 16bb556 into microsoft:main Feb 26, 2023
Code Reviews automation moved this from Ready To Merge to Done Feb 26, 2023
@StephanTLavavej
Copy link
Member

It would take forever to enumerate my thanks! 😹 ♾️ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx23 C++23 feature ranges C++20/23 ranges
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

P2164R9 views::enumerate
3 participants