Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3869 Deprecate std::errc constants related to UNIX STREAMS #3487

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Implement LWG-3869 Deprecate std::errc constants related to UNIX STREAMS #3487

merged 4 commits into from
Feb 23, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #3420.

It seems meaningful to apply the deprecation to older modes, since the changes in the upstream standards (original version of POSIX 2008) predated C++11.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner February 20, 2023 17:55
@github-actions github-actions bot added this to Initial Review in Code Reviews Feb 20, 2023
@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Feb 21, 2023
@CaseyCarter CaseyCarter moved this from Initial Review to Final Review in Code Reviews Feb 21, 2023
@CaseyCarter
Copy link
Member

CaseyCarter commented Feb 21, 2023 •
edited

It seems meaningful to apply the deprecation to older modes, since the changes in the upstream standards (original version of POSIX 2008) predated C++11.

I don't think there's any value to deprecating these in older language modes. Certainly not enough to have to justify doing so to that one customer with an unmaintained fifth-party dependency who has to figure out what to do when we break them.

@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Feb 21, 2023
StephanTLavavej
StephanTLavavej reviewed Feb 22, 2023
View reviewed changes
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

Thanks! FYI @CaseyCarter @strega-nil-ms , I pushed 3 commits: Oxford comma, fix message to mention the correct SILENCE macro, and rename the macros to talk about UNIX_STREAMS plural. Please meow if you have concerns.

@StephanTLavavej StephanTLavavej self-assigned this Feb 22, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 5b20667 into microsoft:main Feb 23, 2023
Code Reviews automation moved this from Ready To Merge to Done Feb 23, 2023
@StephanTLavavej
Copy link
Member

Thanks for warning users away from these useless constants! ⚠️ 😸 🚀

@frederick-vs-ja frederick-vs-ja deleted the lwg-3869 branch February 23, 2023 02:46
@StephanTLavavej StephanTLavavej mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3869 Deprecate std::errc constants related to UNIX STREAMS
4 participants
@frederick-vs-ja @CaseyCarter @StephanTLavavej @strega-nil-ms