Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize modules.json format #3488

Merged
merged 1 commit into from Feb 21, 2023

Conversation

StephanTLavavej
Copy link
Member

@olgaark has requested that modules.json follow a new format before VS 2022 17.6 ships. This simply lists the source files for the Standard Library Modules in an array; the build system will discover what modules they provide, and their dependency relationship. As this has not yet shipped to users for General Availablity, the version number is still specified as 1.0.

@StephanTLavavej StephanTLavavej added enhancement Something can be improved high priority Important! modules C++23 modules, C++20 header units labels Feb 21, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner February 21, 2023 15:38
@github-actions github-actions bot added this to Initial Review in Code Reviews Feb 21, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Feb 21, 2023
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Feb 21, 2023
@StephanTLavavej
Copy link
Member Author

I will merge this into both repos when the checks complete, so that we will have a commit that exactly corresponds to 17.6p3 before we start accumulating 17.7p1 work.

@StephanTLavavej StephanTLavavej merged commit 28a6aab into microsoft:main Feb 21, 2023
Code Reviews automation moved this from Ready To Merge to Done Feb 21, 2023
@StephanTLavavej StephanTLavavej deleted the modules-json branch February 21, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved high priority Important! modules C++23 modules, C++20 header units
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants