Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LWG-3734 Inconsistency in inout_ptr and out_ptr for empty case #3503

Merged
merged 3 commits into from Mar 3, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #3413.

I encountered a regressive bug in 17.6 Preview 1 and reported it as DevCom-10291456.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner February 25, 2023 09:03
@github-actions github-actions bot added this to Initial Review in Code Reviews Feb 25, 2023
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Feb 25, 2023
stl/inc/memory Outdated Show resolved Hide resolved
tests/std/tests/P1132R7_out_ptr/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Feb 25, 2023
@StephanTLavavej
Copy link
Member

Thanks, especially for reporting the compiler regression! I pushed very minor changes.

stl/inc/memory Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Feb 26, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 7155ea6 into microsoft:main Mar 3, 2023
Code Reviews automation moved this from Ready To Merge to Done Mar 3, 2023
@StephanTLavavej
Copy link
Member

Thanks for improving this recently added feature! 😻 🛠️ 🎉

@frederick-vs-ja frederick-vs-ja deleted the lwg-3734 branch March 3, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LWG Library Working Group issue
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

LWG-3734 Inconsistency in inout_ptr and out_ptr for empty case
3 participants