Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-2195 Missing constructors for match_results #3506

Merged
merged 2 commits into from Mar 3, 2023
Merged

Implement LWG-2195 Missing constructors for match_results #3506

merged 2 commits into from Mar 3, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Feb 26, 2023 •
edited

Fixes #3411.

Also adds default member initializers and makes match_results's default constructor defaulted.

The implicitly declared move constructor seems not always noexcept. Should I fix it together?

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner February 26, 2023 09:10
@github-actions github-actions bot added this to Initial Review in Code Reviews Feb 26, 2023
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Feb 26, 2023
@CaseyCarter CaseyCarter mentioned this pull request Feb 26, 2023
Closed
@StephanTLavavej
Copy link
Member

The implicitly declared move constructor seems not always noexcept. Should I fix it together?

I don't think it needs to be changed here. vector's move ctor is noexcept (this is a known untruth in debug mode) so AFAIK match_results gets the right behavior.

@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Feb 28, 2023
@frederick-vs-ja
Copy link
Contributor Author

The implicitly declared move constructor seems not always noexcept. Should I fix it together?

I don't think it needs to be changed here. vector's move ctor is noexcept (this is a known untruth in debug mode) so AFAIK match_results gets the right behavior.

Oh, I meant that the implicitly declared move ctor is currently not noexcept when is_nothrow_move_constructible_v<_BidIt> is false...

@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Feb 28, 2023
@StephanTLavavej StephanTLavavej self-assigned this Mar 2, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 6541cec into microsoft:main Mar 3, 2023
Code Reviews automation moved this from Ready To Merge to Done Mar 3, 2023
@StephanTLavavej
Copy link
Member

Thanks for increasing <regex> conformance, an elusive goal! 🎉 🥅 🎉

@frederick-vs-ja frederick-vs-ja deleted the lwg-2195 branch March 3, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-2195 Missing constructors for match_results
3 participants
@frederick-vs-ja @StephanTLavavej @strega-nil-ms