Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups: Test code using ranges as an identifier, plus more #3528

Merged

Conversation

StephanTLavavej
Copy link
Member

  • P2321R2_views_zip was using ranges as an identifier. 馃檧 Rename this to rngs, avoiding confusion.
  • Dev09_192736_tr1_prngs_not_copyconstructible, written a billion years ago, also had ranges. While this isn't really a problem, let's add a d suffix (also to the following weights), which is consistent with the preceding and following vector<float> rangesf and vector<long double> rangesl.
  • Dev09_056375_locale_cleanup, written a trillion years ago, could use some extremely minor cleanups:
    • Add preprocessor comments.
    • Drop a totally unnecessary using-directive.
      • In general, we should be wary of changing tests in ways that could disturb what they were testing, but there is no way that this had any effect, being scoped to main().
    • Change a C cast to reinterpret_cast.

@StephanTLavavej StephanTLavavej added the test Related to test code label Mar 3, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 3, 2023 20:09
@github-actions github-actions bot added this to Initial Review in Code Reviews Mar 3, 2023
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Mar 3, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Mar 3, 2023
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Mar 6, 2023
@StephanTLavavej StephanTLavavej self-assigned this Mar 7, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a9768b4 into microsoft:main Mar 7, 2023
Code Reviews automation moved this from Ready To Merge to Done Mar 7, 2023
@StephanTLavavej StephanTLavavej deleted the stl-cleanups-test-code branch March 7, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ranges C++20/23 ranges test Related to test code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants