Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups: Very minor logic changes #3531

Merged
merged 3 commits into from Mar 7, 2023
Merged

Cleanups: Very minor logic changes #3531

merged 3 commits into from Mar 7, 2023

Conversation

StephanTLavavej
Copy link
Member

  • Drop break; after return true; in ppltasks.cpp.
    • This was the deadest of dead code. 🧟 🧠
  • In gcd(), fuse break followed by return.
    • There's no other way out of this infinite loop, and no clarity advantage to having the return further away.
  • In fiopen.cpp, change ios_base::openmode atendflag to const bool at_end.
    • We don't modify it, and it's simpler to immediately boil it down to a bool.

@StephanTLavavej
Drop break; after return true; in ppltasks.cpp.
4fc78b5
@StephanTLavavej
In gcd(), fuse break followed by return.
ccb2564 
There's no other way out of this infinite loop.
@StephanTLavavej
fiopen.cpp: Change ios_base::openmode atendflag to `const bool at_e…
418e12a 
…nd`.

We don't modify it, and it's simpler to immediately boil it down to a bool.
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Mar 3, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 3, 2023 20:41
@github-actions github-actions bot added this to Initial Review in Code Reviews Mar 3, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Mar 3, 2023
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Mar 6, 2023
@StephanTLavavej StephanTLavavej self-assigned this Mar 7, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 1e066dc into microsoft:main Mar 7, 2023
Code Reviews automation moved this from Ready To Merge to Done Mar 7, 2023
@StephanTLavavej StephanTLavavej deleted the stl-cleanups-minor-logic-changes branch March 7, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StephanTLavavej @strega-nil-ms