Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode 15 #3556

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Unicode 15 #3556

merged 2 commits into from
Mar 17, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Mar 10, 2023 •
edited

  • Update __msvc_format_ucd_tables.hpp,
  • P0645R10_text_formatting_grapheme_clusterization\test.cpp is the same as before,
  • Update links to Unicode files, using recommendation from https://unicode.org/versions/#Contributory_Data_Files:

    The latest versions of all of the Unicode Character Database files are kept in https://www.unicode.org/Public/UCD/latest/. These files have no version number suffix, so that a link to a file in that directory will always point to the latest version.

  • Extra changes to scripts:
    • Use snake_case instead of camelCase when naming functions (PEP8),
    • grapheme_break_property_data_gen.py - generate comment with filename and timestamp for each enum and array,
    • grapheme_break_test_data_gen.py - generate comment with filename and timestamp for entire test,
  • Add comment referencing P2736R2 in C++20 section and close P2736R2 Referencing The Unicode Standard #3456.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner March 10, 2023 12:04
@github-actions github-actions bot added this to Initial Review in Code Reviews Mar 10, 2023
@StephanTLavavej StephanTLavavej added format C++20/23 format cxx23 C++23 feature labels Mar 10, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Mar 12, 2023
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Mar 13, 2023
@StephanTLavavej StephanTLavavej self-assigned this Mar 16, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit cf89890 into microsoft:main Mar 17, 2023
Code Reviews automation moved this from Ready To Merge to Done Mar 17, 2023
@StephanTLavavej
Copy link
Member

🛜 🪿 🩶

@JMazurkiewicz JMazurkiewicz deleted the unicode15 branch March 17, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barcharcraz barcharcraz barcharcraz approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature format C++20/23 format
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2736R2 Referencing The Unicode Standard
4 participants
@JMazurkiewicz @StephanTLavavej @barcharcraz @strega-nil-ms