Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2374R4: views::cartesian_product #3561

Merged
merged 47 commits into from
Mar 30, 2023
Merged

P2374R4: views::cartesian_product #3561

merged 47 commits into from
Mar 30, 2023

Commits on Mar 7, 2023

  1. Feature test macro

    @JMazurkiewicz
    JMazurkiewicz committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    92a9735 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. Implement views::cartesian_product

    @JMazurkiewicz
    JMazurkiewicz committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    d7ea13d View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Simplify _Cartesian_product_is_common

    @JMazurkiewicz
    JMazurkiewicz committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    550cb1d View commit details
    Browse the repository at this point in the history

  2. Apply @tylerbrawl's suggestion

    @JMazurkiewicz
    JMazurkiewicz committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c1c2c8c View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Merge remote-tracking branch 'upstream/main' into descartes

    @JMazurkiewicz
    JMazurkiewicz committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    0e22346 View commit details
    Browse the repository at this point in the history

  2. Remove workaround for microsoftGH-3550

    @JMazurkiewicz
    JMazurkiewicz committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    9c9ad33 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2023

  1. Merge branch 'main' into descartes

    @StephanTLavavej
    StephanTLavavej committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    86a83e5 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Make _Left and _Right arguments const in `_(Multiply/Add)_with_ov… 

    …erflow_check`

microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    cb8b529 View commit details
    Browse the repository at this point in the history

  2. Remove static from _Cartesian_product_optimal_size_type 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    f3bb665 View commit details
    Browse the repository at this point in the history

  3. _Range_size -> _Size 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    72d6cbf View commit details
    Browse the repository at this point in the history

  4. *((*this) + _Off) -> *(*this + _Off) 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    c9b6490 View commit details
    Browse the repository at this point in the history

  5. operator-: difference_type _Off should be const 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    f5f502f View commit details
    Browse the repository at this point in the history

  6. iter_swap should be just friend

    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    8525f6b View commit details
    Browse the repository at this point in the history

  7. _FirstBase, _OtherBases -> _First_base, _Other_bases 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    95a9d02 View commit details
    Browse the repository at this point in the history

  8. Add ^^^ for _CONTAINER_DEBUG_LEVEL == 0 comment 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    31035c3 View commit details
    Browse the repository at this point in the history

  9. Add LLVM banner and remove link to file - permalink is too long :( 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1e01347 View commit details
    Browse the repository at this point in the history

  10. Add alias for _Difference_type in _Advance 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    428d3e4 View commit details
    Browse the repository at this point in the history

  11. Yeet away internal assertion 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    6a93338 View commit details
    Browse the repository at this point in the history

  12. 🐿️ ⚔ ^ 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    759879c View commit details
    Browse the repository at this point in the history

  13. Don't mention internal machinery: _Size_type<> -> size type 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    8923a30 View commit details
    Browse the repository at this point in the history

  14. consteval -> _CONSTEVAL for both cartesian_product and `adjacen… 

    …t_transform` (as drive-by)

microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    eab66c1 View commit details
    Browse the repository at this point in the history

  15. Use permalink to LLVM code 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    3a3f595 View commit details
    Browse the repository at this point in the history

  16. Cast to _Int to avoid truncation warnings 

    https://github.com/microsoft/STL/pull/3561/files/86a83e58605c909eddba7be763c86cbfc9a7c17f#r1142788979
microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e18ae03 View commit details
    Browse the repository at this point in the history

  17. Fix formatting

    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    90ed880 View commit details
    Browse the repository at this point in the history

  18. Change overflow detection method 

    microsoft#3561 (comment)
    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    fcf5469 View commit details
    Browse the repository at this point in the history

  19. Fix CI

    @JMazurkiewicz
    JMazurkiewicz committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    feb062c View commit details
    Browse the repository at this point in the history

  20. Perform overflow checking in the iterator for IDL != 0.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    91284ba View commit details
    Browse the repository at this point in the history

  21. ranges::input_range was repeated.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    8d727c7 View commit details
    Browse the repository at this point in the history

  22. ranges::iterator_t was unnecessarily qualified.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    41bfec1 View commit details
    Browse the repository at this point in the history

  23. Improve clang-formatting.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1a0562c View commit details
    Browse the repository at this point in the history

  24. Comment nitpicks.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    98b3a7d View commit details
    Browse the repository at this point in the history

  25. Fix is_iter_swap_nothrow() to call ranges::iter_swap with 2 args.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    a916aef View commit details
    Browse the repository at this point in the history

  26. Test modifiable elements to exercise is_iter_swap_nothrow.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    0296071 View commit details
    Browse the repository at this point in the history

  27. We take input_range First so this is guaranteed.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    d9e4dfa View commit details
    Browse the repository at this point in the history

  28. cartesian_view => cartesian_product_view

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    7b91690 View commit details
    Browse the repository at this point in the history

  29. Include <tuple>, <utility>.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    16b2db4 View commit details
    Browse the repository at this point in the history

  30. Drop unnecessary parens.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ce0f0b3 View commit details
    Browse the repository at this point in the history

  31. size => expected_size

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    83866ac View commit details
    Browse the repository at this point in the history

  32. Check forward_range<const VFirst> when testing const iterators.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    931f348 View commit details
    Browse the repository at this point in the history

  33. Drop copy-pasted code that isn't testing mixed comparisons.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    b9b776e View commit details
    Browse the repository at this point in the history

  34. Add missing consts when calling is_iter_swap_nothrow.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    198b5f1 View commit details
    Browse the repository at this point in the history

  35. Drop Indices in is_iter_move_nothrow, is_iter_swap_nothrow.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    11f61e1 View commit details
    Browse the repository at this point in the history

  36. Extend test_iter_swap() to check is_iter_swap_nothrow.

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    530b69f View commit details
    Browse the repository at this point in the history

  37. Don't need to check defined(_MT).

    @StephanTLavavej
    StephanTLavavej committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    bcd5814 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Merge branch 'main' into descartes

    @StephanTLavavej
    StephanTLavavej committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    f1832eb View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Merge branch 'main' into descartes

    @StephanTLavavej
    StephanTLavavej committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    528b2a9 View commit details
    Browse the repository at this point in the history

  2. Work around /analyze bugs.

    @StephanTLavavej
    StephanTLavavej committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    0fc54a9 View commit details
    Browse the repository at this point in the history