Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LWG-3887 Version macro for allocate_at_least #3589

Merged
merged 2 commits into from Mar 28, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Mar 24, 2023

The change has been adoped into the C++ Working Draft by commit cplusplus/draft@6e7fd98. However, it isn't contained in WG21-N4944. A newer WD (and perhaps the published C++23 Standard?) will contain it.

Driven-by change: concept dependency of allocator_at_least was removed by #3542, so the feature-test macro should also be enabled even if the concept support is absent.

And make `__cpp_lib_allocate_at_least` not dependent on concept support.
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 24, 2023 01:40
@github-actions github-actions bot added this to Initial Review in Code Reviews Mar 24, 2023
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Mar 24, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Mar 24, 2023
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Mar 24, 2023
@StephanTLavavej StephanTLavavej self-assigned this Mar 28, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit f00f51e into microsoft:main Mar 28, 2023
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done Mar 28, 2023
@StephanTLavavej
Copy link
Member

Thanks for keeping up with this rapidly evolving Standard! 😸 🎉 ✅

@frederick-vs-ja frederick-vs-ja deleted the lwg-3887 branch March 28, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LWG Library Working Group issue
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants