Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups for <mutex> etc. #3759

Merged
merged 3 commits into from Jun 15, 2023
Merged

Cleanups for <mutex> etc. #3759

merged 3 commits into from Jun 15, 2023

Conversation

achabense
Copy link
Contributor

@achabense achabense commented Jun 10, 2023 •
edited

  • Removes condition_variable::_Wait_until1(...const _timespec64*...), which is not called anywhere.
  • Fuses some ugly methods like timed_mutex::_Try_lock_until.

@achabense achabense requested a review from a team as a code owner June 10, 2023 16:08
@github-actions github-actions bot added this to Initial Review in Code Reviews Jun 10, 2023
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jun 10, 2023
StephanTLavavej
StephanTLavavej approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Jun 10, 2023
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Jun 14, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jun 14, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 641dd9b into microsoft:main Jun 15, 2023
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done Jun 15, 2023
@StephanTLavavej
Copy link
Member

Thanks for clearing out even more dead code! 💀 ☠️ 🪄

@achabense achabense deleted the _For_Mutex_Cleanups branch June 15, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achabense @StephanTLavavej @strega-nil-ms