Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<functional>: Make function::target return null function pointers without cast #3844

Merged
merged 1 commit into from Jul 14, 2023
Merged

<functional>: Make function::target return null function pointers without cast #3844

merged 1 commit into from Jul 14, 2023
+25 −2

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #3843.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner July 1, 2023 07:03
@github-actions github-actions bot added this to Initial Review in Code Reviews Jul 1, 2023
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Jul 1, 2023
@StephanTLavavej
Copy link
Member

Perfect, thank you!! 😻

@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Jul 3, 2023
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Jul 5, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jul 13, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 85eb9b6 into microsoft:main Jul 14, 2023
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done Jul 14, 2023
@StephanTLavavej
Copy link
Member

Thanks for fixing compiler errors in this corner case! 🎉 😺 ✅

@frederick-vs-ja frederick-vs-ja deleted the function-target branch July 14, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<functional>: Clang error when calling target() on a const function
3 participants
@frederick-vs-ja @StephanTLavavej @strega-nil-ms