Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.7 Preview 3, Clang 16.0.5 #3866

Merged
merged 24 commits into from Jul 14, 2023

Conversation

StephanTLavavej
Copy link
Member

  • Remove workarounds for VSO-1664463 "/clr C++20 alignas emits error C3821 'managed type or function cannot be used in an unmanaged function' instead of falling back to native codegen".
  • Remove workarounds for VSO-1152705 "_malloca_crt should suppress PREfast warning 6386".
  • Remove workaround for DevCom-10334808 "Pointer operands are not correctly converted to the composite pointer type in three-way comparison".
  • Followup changes after Avoid new warning C5267 for deprecated implicit copy ctor/assign #3497.
    • Enable the recently-added, off-by-default warning C5267 (for deprecated copy constructors and copy assignment operators) in the std and tr1 test suites to ensure that we remain clean. (libcxx contains too many occurrences in its own code to make this feasible.)
    • Fix aligned_type in P0220R1_any to avoid the warning. We need to work around VSO-1846195 "/clr alignas emits fatal error C1193: an error expected in yyaction.cpp(2971) not reached".
  • Require Node.js 20.4.0 when building the Status Chart.
  • Go back to Standard_D32ds_v5. This is an attempt to avoid stalled checks, although it probably won't help.
  • Use PowerShell 7.3.5 to build the pool.
  • New pool.
  • VS 2022 17.7 Preview 3 contains Clang 16.0.5.
  • Remove <xtree> workaround for VSO-761321 "Failure with local type alias in if constexpr condition", which was fixed at some point.
  • 17.7 Preview 3 fixes Clang in VS 17.7p1 doesn't grok _addcarry_u64/_subborrow_u64 #3713, so we can revert the workarounds that I had to introduce in Toolset update: VS 2022 17.7 Preview 1 #3711:
    • _addcarry_u64/_subborrow_u64
    • LDBL_DECIMAL_DIG
    • tgmath.h
  • Remove workaround for LLVM-62762 "32-bit-only misoptimization of printf calls on Windows", fixed by Clang 16.0.3.
  • Style followup from Toolset update: VS 2022 17.7 Preview 1 #3711: Attach // TRANSITION, VSO-1690654 comment.
  • Style followup from Toolset update: VS 2022 17.7 Preview 1 #3711: Attempt to improve formatting of _Can_construct_from_tuple_like.
  • Remove workaround for VSO-1285779 "EDG rejects source_location intrinsics within consteval functions".
    • This was fixed on 2021-09-07 in VS 2022 17.0.
  • Remove workaround for VSO-1268984 "New compiler intrinsics for Layout-compatibility and Pointer-interconvertibility Traits need to be understood by EDG".
    • This was fixed on 2022-03-07 in VS 2022 17.2.
  • Remove workaround for VSO-657455 "EDG: dependent name in nested generic lambda not seen as dependent".
    • This was fixed on 2023-01-04 in VS 2022 17.5.
  • Rerun clang-format 16.0.5, no manual changes.
  • Add workarounds for VSO-1849453 "EDG mishandles is_pointer_interconvertible_base_of_v<EmptyBase, StatefulDerived>".
  • Add workaround for VSO-1849458 "EDG mishandles is_layout_compatible_v<const int[], int[]>".
  • Perma-workaround EDG behavioral differences in source_location::column().
    • I consider column() to be relatively unimportant and I don't think that these behavioral differences are worth reporting.
  • Add workaround for VSO-1849463 "EDG silently rejects source_location::current() as a default argument".

x86chk stlimport passed internally.

StephanTLavavej and others added 24 commits July 6, 2023 02:30
…functions" was fixed on 2021-09-07 in VS 2022 17.0.
…nter-interconvertibility Traits need to be understood by EDG" was fixed on 2022-03-07 in VS 2022 17.2.
…dependent" was fixed on 2023-01-04 in VS 2022 17.5.
…rtible_base_of_v<EmptyBase, StatefulDerived>".
@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Jul 12, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner July 12, 2023 05:32
@github-actions github-actions bot added this to Initial Review in Code Reviews Jul 12, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Jul 12, 2023
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Jul 12, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jul 13, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 23a5a53 into microsoft:main Jul 14, 2023
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done Jul 14, 2023
@StephanTLavavej StephanTLavavej deleted the vs17.7p3 branch July 14, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Clang in VS 17.7p1 doesn't grok _addcarry_u64/_subborrow_u64
2 participants