`<filesystem>`: fix dangerous `noexcept` specification of `_Current_path` #3869

achabense · 2023-07-12T15:44:44Z

_Current_path is wrongly marked as noexcept, which will cause the program to terminate if resize throws.

Lines 4045 to 4046 in 2261f7e

    
           _NODISCARD inline __std_win_error _Current_path(path& _Result) noexcept {
 
               _Result._Text.resize(__std_fs_max_path);

This pr fixes it by merging the function into throwable path current_path(error_code&).

…de&)`

stl/inc/filesystem

StephanTLavavej · 2023-07-13T01:04:47Z

Great catch, thanks! 😻 I couldn't resist pushing a stylistic nitpick even though this resets testing.

StephanTLavavej · 2023-07-13T02:46:10Z

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej · 2023-07-14T02:49:32Z

Thanks for noticing and fixing this silent bad codegen! 🦅 👁️ ✅

merge _Current_path(path&)noexcept into `path current_path(error_co…

c841928

…de&)`

achabense requested a review from a team as a code owner July 12, 2023 15:44

github-actions bot added this to Initial Review in Code Reviews Jul 12, 2023

StephanTLavavej added bug Something isn't working filesystem C++17 filesystem labels Jul 12, 2023

StephanTLavavej self-assigned this Jul 12, 2023

Code review feedback.

d1d7f14

StephanTLavavej reviewed Jul 13, 2023

View reviewed changes

stl/inc/filesystem Outdated Show resolved Hide resolved

StephanTLavavej approved these changes Jul 13, 2023

View reviewed changes

StephanTLavavej removed their assignment Jul 13, 2023

StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Jul 13, 2023

StephanTLavavej self-assigned this Jul 13, 2023

strega-nil-ms approved these changes Jul 13, 2023

View reviewed changes

StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Jul 13, 2023

StephanTLavavej merged commit f51733c into microsoft:main Jul 14, 2023
35 checks passed

Code Reviews automation moved this from Ready To Merge to Done Jul 14, 2023

achabense deleted the _FS_noexcept_fix branch July 14, 2023 12:57

Provide feedback

	_NODISCARD inline __std_win_error _Current_path(path& _Result) noexcept {
	_Result._Text.resize(__std_fs_max_path);