Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary typenames for all standard headers introduced in C++20 #3893

Conversation

achabense
Copy link
Contributor

@achabense achabense commented Jul 20, 2023

The headers newly introduced in C++20 are:

<bit>
<compare>
<concepts>
<coroutine>
<format>
<numbers>
<ranges>
<source_location>
<span>
<syncstream>
<version>
<barrier>
<latch>
<semaphore>
<stop_token>

The headers that contain typename are:

<compare>: Removes two `typename` in `using` clauses; one left as necessary.
<concepts>: All necessary.
<coroutine>: X(Removes one in `using` clause; one left as necessary) update: kept unchanged
<format>: Tackled in last pr.
<numbers>: Removes the only one.
<ranges>: Removes those in `using` clause; the rest(a lot) are necessary.
<span>: All necessary.
<syncstream>: Removes those in `using` clause; one left as necessary.

Also removes all typename in <stacktrace>

Works towards #3718.

@achabense achabense requested a review from a team as a code owner July 20, 2023 19:50
@github-actions github-actions bot added this to Initial Review in Code Reviews Jul 20, 2023
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Jul 20, 2023
stl/inc/coroutine Outdated Show resolved Hide resolved
Code Reviews automation moved this from Initial Review to Work In Progress Jul 20, 2023
Co-authored-by: Casey Carter <cartec69@gmail.com>
@StephanTLavavej
Copy link
Member

Thanks! BTW I have changes to clean up all other headers, I will create a separate PR.

@StephanTLavavej StephanTLavavej moved this from Work In Progress to Initial Review in Code Reviews Jul 20, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Jul 20, 2023
@StephanTLavavej StephanTLavavej changed the title Remove unnecessary typenames for all standard headers introduced in C++20 Remove unnecessary typenames for all standard headers introduced in C++20 Jul 20, 2023
@CaseyCarter CaseyCarter removed their assignment Jul 20, 2023
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Jul 20, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jul 25, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 70551bd into microsoft:main Jul 26, 2023
35 checks passed
Code Reviews automation moved this from Ready To Merge to Done Jul 26, 2023
@StephanTLavavej
Copy link
Member

Thanks for these additional typename cleanups! 📈 🧹 😻

@achabense achabense deleted the _Typename_cleanup_for_cpp20_std_headers branch July 30, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants