Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups for don't-call functions #3905

Merged
merged 1 commit into from Jul 26, 2023
Merged

Cleanups for don't-call functions #3905

merged 1 commit into from Jul 26, 2023

Conversation

achabense
Copy link
Contributor

Towards #3888

@achabense achabense requested a review from a team as a code owner July 25, 2023 17:46
@github-actions github-actions bot added this to Initial Review in Code Reviews Jul 25, 2023
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jul 25, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Jul 25, 2023
CaseyCarter
CaseyCarter approved these changes Jul 25, 2023
View reviewed changes
stl/inc/future Show resolved Hide resolved
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Jul 25, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jul 25, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0fe653a into microsoft:main Jul 26, 2023
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done Jul 26, 2023
@StephanTLavavej
Copy link
Member

Thanks for these consistency improvements! 😺 🎉 ✨

@achabense achabense deleted the _Dontcall_cleanup branch July 30, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achabense @StephanTLavavej @CaseyCarter