Call abort() in terribly broken states
#3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one seem to be mandated by exception from parallel algorithm requirement and so it is odd that there's an attempt to fastfail before termitate. |
StephanTLavavej
approved these changes
Jul 26, 2023
* Qualify all calls to "pretty" names in `excptrptr.cpp`, `filesystem.cpp`, `primitives.hpp`, and `iosptrs.cpp` * Don't qualify calls to "pretty" names in `mutex.cpp` and `stacktrace.cpp`
CaseyCarter
approved these changes
Jul 27, 2023
This reverts commit 327c5f6. This is too much change for this tiny PR. I'll make the files consistent in a followup.
* Don't qualify only the call to `abort` in `mutex.cpp`. * Don't call `_CSTD abort` in `stacktrace.cpp` when all other such calls are `std::`-qualified
CaseyCarter
approved these changes
Jul 27, 2023
StephanTLavavej
approved these changes
Jul 27, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🚨 💥 ☠️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3888
The following cases do not require
terminate(), changed toabort():_Ref_count_basein<memory>for/crl:pure. That was pure call surrogate. Pure CLR can't handle pure calls_Execute_onceinexcptptr.cpp. It doesn't fail if callback doesn't fail (and the sync object isn't broken)filesystem.cpp. Fail with broken or already closed handles. Catch that with debugger / app verifier, otherwiseabort().Deliberately omitted
ppltask.cpp- not sure about that. Looks like that's the last oddterminate(), otherterminate()s look legit