Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: check c(begin|end) members of some C++23 ranges #3920

Merged
merged 8 commits into from Aug 11, 2023
Merged

Testing: check c(begin|end) members of some C++23 ranges #3920

merged 8 commits into from Aug 11, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

Towards #3391.

I've encountered some compiler issues with other C++23 range adaptors, so this PR only covers 3 of them.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner August 2, 2023 13:09
@github-actions github-actions bot added this to Initial Review in Code Reviews Aug 2, 2023
@JMazurkiewicz JMazurkiewicz mentioned this pull request Aug 2, 2023
Open
34 tasks
@StephanTLavavej StephanTLavavej added test Related to test code ranges C++20/23 ranges labels Aug 2, 2023
@StephanTLavavej StephanTLavavej self-assigned this Aug 2, 2023
StephanTLavavej
StephanTLavavej reviewed Aug 2, 2023
View reviewed changes
tests/std/tests/P1899R3_views_stride/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P1899R3_views_stride/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P1899R3_views_stride/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P2278R4_views_as_const/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P2278R4_views_as_const/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Aug 2, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Aug 2, 2023
@StephanTLavavej
Copy link
Member

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

I've pushed an additional commit to work around #1030 by imitating P2321R2_views_zip_transform. This test was apparently quite close to running out of compiler memory (also #3567) and the extra tests pushed it over the limit for the internal compiler. Instead of guarding just the newly added code, I chose to dramatically reduce how much we test with /analyze, to exactly follow what P2321R2_views_zip_transform is already doing.

@CaseyCarter CaseyCarter removed their assignment Aug 10, 2023
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Aug 10, 2023
@StephanTLavavej StephanTLavavej merged commit 06fef80 into microsoft:main Aug 11, 2023
35 checks passed
Code Reviews automation moved this from Ready To Merge to Done Aug 11, 2023
@StephanTLavavej
Copy link
Member

Thanks for continuing to enhance this test coverage! ✅ ✅ ✅

@JMazurkiewicz JMazurkiewicz deleted the ranges/const branch August 11, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
ranges C++20/23 ranges test Related to test code
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JMazurkiewicz @StephanTLavavej @CaseyCarter