Update #else transition comment
#3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards microsoft#351. I'm not sure which is really TRANSITION, so I want this reviewed separately.
CaseyCarter
reviewed
Aug 11, 2023
CaseyCarter
approved these changes
Aug 11, 2023
StephanTLavavej
approved these changes
Aug 11, 2023
| @@ -676,7 +676,7 @@ _NODISCARD const _Ty& _Immortalize_memcpy_image() noexcept { | |||
| static _Constexpr_immortalize_impl<_Ty> _Static; | |||
| return _Static._Storage; | |||
| } | |||
| #else // ^^^ no workaround / workaround vvv | |||
| #else // ^^^ !defined(_M_CEE) / defined(_M_CEE), TRANSITION, VSO-1153256 vvv | |||
There was a problem hiding this comment.
No change requested: There are two spaces here but it's not worth resetting testing, I'll fix it up later.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🧹 📜 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #351.
I'm not sure which is really TRANSITION,
so I want this reviewed separately.