Make the constexpr mutex constructor opt-in #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
added
bug
... via defining `_ENABLE_CONSTEXPR_MUTEX_CONSTRUCTOR`, instead of opt-out via `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR`. This avoids potential breakage until we can update the VCLibs UWP framework libraries.
CaseyCarter
changed the title
constexpr mutex constructor" changes
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
strega-nil-ms
approved these changes
Aug 30, 2023
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Jan 24, 2024
This reverts commit 782dcd5.
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Jan 24, 2024
This reverts commit 782dcd5. Fixes microsoft#4338
StephanTLavavej
added a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... via defining
_ENABLE_CONSTEXPR_MUTEX_CONSTRUCTOR, instead of opt-out via_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR. This avoids potential breakage until we can update the VCLibs UWP framework libraries. Doing so in time for 17.8 is probably impossible at this late stage; we'll get this straightened out and enabled by default for 17.9.