Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<istream>, <ostream>: Deprecate pre-Standard ipfx, isfx, opfx, and osfx functions #4006

Merged
merged 3 commits into from Sep 14, 2023
Merged

<istream>, <ostream>: Deprecate pre-Standard ipfx, isfx, opfx, and osfx functions #4006

merged 3 commits into from Sep 14, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

I found that these functions were present in some early prehistoric working drafts but removed before C++98 (see WG21-N0794 for rationale). I think it's helpful to say sentry classes should be used instead.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner September 3, 2023 16:20
@github-actions github-actions bot added this to Initial Review in Code Reviews Sep 3, 2023
JMazurkiewicz
JMazurkiewicz reviewed Sep 3, 2023
View reviewed changes
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
frederick-vs-ja and others added 2 commits September 4, 2023 07:11
@frederick-vs-ja @JMazurkiewicz
Fix typo
df5497e 
Co-authored-by: Jakub Mazurkiewicz <mazkuba3@gmail.com>
@frederick-vs-ja
Space
4d72dc9
@StephanTLavavej StephanTLavavej self-assigned this Sep 5, 2023
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Sep 5, 2023
@StephanTLavavej StephanTLavavej removed their assignment Sep 7, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Sep 7, 2023
@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Sep 8, 2023
@StephanTLavavej StephanTLavavej self-assigned this Sep 13, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 9858519 into microsoft:main Sep 14, 2023
35 checks passed
Code Reviews automation moved this from Ready To Merge to Done Sep 14, 2023
@StephanTLavavej
Copy link
Member

Thanks for deprecating these pre-Cambrian functions! ☠️ 🦴 🚀

@frederick-vs-ja frederick-vs-ja deleted the deprecate-io-pfx-sfx branch September 14, 2023 23:30
@StephanTLavavej StephanTLavavej mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMazurkiewicz JMazurkiewicz JMazurkiewicz left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frederick-vs-ja @StephanTLavavej @JMazurkiewicz @strega-nil-ms