Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary #include "awint.hpp" #4015

Merged
merged 2 commits into from Sep 14, 2023
Merged

Remove unnecessary #include "awint.hpp" #4015

merged 2 commits into from Sep 14, 2023

Conversation

grcm10
Copy link
Contributor

@grcm10 grcm10 commented Sep 8, 2023

Resolve #3937

@grcm10 grcm10 requested a review from a team as a code owner September 8, 2023 07:45
@github-actions github-actions bot added this to Initial Review in Code Reviews Sep 8, 2023
@grcm10
Copy link
Contributor Author

grcm10 commented Sep 8, 2023

@microsoft-github-policy-service agree

@AlexGuteniev
Copy link
Contributor

clang-format format validation fails, looks like it does not want extra newline between standard includes

https://dev.azure.com/vclibs/STL/_build/results?buildId=14978&view=logs&j=ce9c9df7-f6fa-59cf-0934-3339753bfc56&t=c6e68a6e-a0d3-5ff7-0941-3a725df1e075

frederick-vs-ja
frederick-vs-ja reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<yvals.h> is already included by several other standard headers, so we don't need to additionally include it.

stl/src/winapisupp.cpp Show resolved Hide resolved
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Sep 8, 2023
@StephanTLavavej StephanTLavavej self-assigned this Sep 8, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Sep 8, 2023
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Sep 8, 2023
@StephanTLavavej
Copy link
Member

Thanks! I double-checked the codebase, by searching for all mentions of awint.hpp and excluding those files that were mentioning things declared by awint.hpp, and found that winapinls.cpp no longer needed it, so I pushed an additional change.

@StephanTLavavej StephanTLavavej removed their assignment Sep 8, 2023
@grcm10
Copy link
Contributor Author

grcm10 commented Sep 9, 2023

Thank you all for the review!

@StephanTLavavej StephanTLavavej self-assigned this Sep 13, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit bb0f43a into microsoft:main Sep 14, 2023
35 checks passed
Code Reviews automation moved this from Ready To Merge to Done Sep 14, 2023
@StephanTLavavej
Copy link
Member

Thanks again for cleaning up this code! 🧹 😸 🎉

@grcm10 grcm10 deleted the awinthpp branch September 17, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup #include "awint.hpp"
5 participants
@grcm10 @AlexGuteniev @StephanTLavavej @CaseyCarter @frederick-vs-ja