Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.8 Preview 3 #4083

Merged
merged 10 commits into from Oct 14, 2023

Conversation

StephanTLavavej
Copy link
Member

  • Updated dependencies.
    • Updated build compiler to VS 2022 17.8 Preview 3.
    • Updated Python to 3.12.0 (now required).
  • Remove compiler bug workarounds:
    • Remove workaround for VSO-1826196 "False positive C26454 in charconv" as the internal toolset has been updated. Validated internally, we can resolve this bug when merging.
    • Drop TRANSITION comment about VSO-251998 "File issue for cbegin interaction with other std containers with only non-member begin() functions". This wasn't a compiler or STL bug; it was a reminder to maybe file an LWG issue someday, which never happened and isn't worth pursuing now.
    • VSO-1281038 "False C6287 for C++20 synthesized operators" was rightfully resolved as By Design. Permanently avoid it by separately asserting each expression, which is our preferred style anyways.
      • Although we generally avoid cleaning up tr1, this is worth it.
    • Remove workaround for VSO-1538014 "[Feedback] ARM64 memchr implementation may not be standard conformant". It was fixed on 2023-06-02 by MSVC-PR-468038 in prod/be and is present in both rel/17.7 and rel/17.8. It was marked as fixed in 17.8 Preview 1.
    • Replace coarse-grained workaround for VSO-1026729 "Conformant Copy Elision" (a User Story that's been Proposed since 2019-11-22) with fine-grained workarounds for VSO-1899423 "C1XX mishandles C++17 deferred temporary materialization in is_invocable_r_v and is_nothrow_invocable_r_v" (newly reported with this exact code).
  • Use PowerShell 7.3.8 to create the pool.

… as the internal toolset has been updated. Validated internally, we can resolve this bug when merging.
…action with other std containers with only non-member begin() functions". This wasn't a compiler or STL bug; it was a reminder to maybe file an LWG issue someday, which never happened and isn't worth pursuing now.
…lly resolved as By Design. Permanently avoid it by separately asserting each expression, which is our preferred style anyways.
…tion may not be standard conformant". It was fixed on 2023-06-02 by MSVC-PR-468038 in prod/be and is present in both rel/17.7 and rel/17.8. It was marked as fixed in 17.8 Preview 1.
…ision" (a User Story that's been Proposed since 2019-11-22) with fine-grained workarounds for VSO-1899423 "C1XX mishandles C++17 deferred temporary materialization in is_invocable_r_v and is_nothrow_invocable_r_v" (newly reported with this exact code).
@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Oct 11, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner October 11, 2023 05:39
@github-actions github-actions bot added this to Initial Review in Code Reviews Oct 11, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Oct 11, 2023
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Oct 11, 2023
@StephanTLavavej StephanTLavavej self-assigned this Oct 13, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 05b3152 into microsoft:main Oct 14, 2023
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done Oct 14, 2023
@StephanTLavavej StephanTLavavej deleted the vs17.8p3 branch October 14, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants