Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update return type of iter_move to decltype(auto) #4167

Conversation

Rageking8
Copy link
Contributor

Fixes #4157

@Rageking8 Rageking8 requested a review from a team as a code owner November 12, 2023 17:39
@github-actions github-actions bot added this to Initial Review in Code Reviews Nov 12, 2023
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Nov 12, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in Code Reviews Nov 12, 2023
@StephanTLavavej StephanTLavavej self-assigned this Nov 16, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 09dab6c into microsoft:main Nov 17, 2023
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done Nov 17, 2023
@StephanTLavavej
Copy link
Member

Thanks for implementing this LWG issue resolution, and congratulations on your first microsoft/STL commit! 🎉 😻 🚀

This will ship in VS 2022 17.9 Preview 3.

@StephanTLavavej
Copy link
Member

Correction: This will actually ship in VS 2022 17.10 Preview 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LWG Library Working Group issue
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

LWG-3953 iter_move for common_iterator and counted_iterator should return decltype(auto)
2 participants