Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3897 inout_ptr will not update raw pointer to null #4186

Merged
merged 2 commits into from Nov 17, 2023
Merged

Implement LWG-3897 inout_ptr will not update raw pointer to null #4186

merged 2 commits into from Nov 17, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4160.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner November 13, 2023 15:24
@github-actions github-actions bot added this to Initial Review in Code Reviews Nov 13, 2023
Code Reviews automation moved this from Initial Review to Done Nov 13, 2023
Code Reviews automation moved this from Done to Initial Review Nov 13, 2023
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Nov 13, 2023
@StephanTLavavej StephanTLavavej self-assigned this Nov 13, 2023
StephanTLavavej
StephanTLavavej reviewed Nov 13, 2023
View reviewed changes
stl/inc/memory Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Nov 13, 2023
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in Code Reviews Nov 13, 2023
@StephanTLavavej
Copy link
Member

Thanks! I pushed a commit to simplify the control flow. I think this needs only one maintainer approval.

@StephanTLavavej StephanTLavavej self-assigned this Nov 16, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit ae15359 into microsoft:main Nov 17, 2023
35 checks passed
Code Reviews automation moved this from Ready To Merge to Done Nov 17, 2023
@StephanTLavavej
Copy link
Member

📥 📤 ✖️

@frederick-vs-ja frederick-vs-ja deleted the lwg-3897 branch November 17, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3897 inout_ptr will not update raw pointer to null
2 participants
@frederick-vs-ja @StephanTLavavej