<mdspan>: Check preconditions of mdspan::operator[] clarified by LWG-3974
#4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
lwg-3974
branch
from
6ad916c
to
a82957c
Compare
CaseyCarter
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Just a static_assert message nit, which I'll apply.
I believe the original implementation is conforming after LWG-3974, because the difference between
index-castandstatic_castcan't be observed without UB (precondition violation).
That was my determination as well when LWG suggested changing the resolution to use index-cast.
Clarify `static_assert` message.
StephanTLavavej
approved these changes
Nov 28, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for improving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4166.
I believe the original implementation is conforming after LWG-3974, because the difference between
index-castandstatic_castcan't be observed without UB (precondition violation). This PR intends to improve precondition checking.