Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<type_traits>: Workaround for DevCom-10543093 (ICE with some uses of pointers to data members) #4277

Merged

Conversation

frederick-vs-ja
Copy link
Contributor

The bug was not previously analyzed. I reduced the test case and reported DevCom-10543093.

Unblocks one libcxx test:

  • std/utilities/function.objects/func.invoke/invoke_constexpr.pass.cpp

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner December 18, 2023 03:06
@github-actions github-actions bot added this to Initial Review in Code Reviews Dec 18, 2023
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Dec 18, 2023
@StephanTLavavej StephanTLavavej self-assigned this Dec 18, 2023
@CaseyCarter CaseyCarter moved this from Initial Review to Final Review in Code Reviews Jan 9, 2024
@CaseyCarter
Copy link
Member

The compiler bug should be fixed in 17.10p1, so this workaround ideally won't be around long.

@StephanTLavavej StephanTLavavej removed their assignment Jan 10, 2024
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Jan 10, 2024
@StephanTLavavej StephanTLavavej self-assigned this Jan 11, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 7a3a4a5 into microsoft:main Jan 11, 2024
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done Jan 11, 2024
@StephanTLavavej
Copy link
Member

Thanks for investigating and fixing this libcxx failure, and reporting the compiler bug too! This is awesome! 🐞 😻 🎉

@frederick-vs-ja frederick-vs-ja deleted the workaround-invoke-pmd branch January 11, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants