Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups: ppltasks.cpp #4445

Merged

Conversation

StephanTLavavej
Copy link
Member

I've validated this with an internal build and test run. I know there's not a lot of value in cleaning up old src files, but this eliminates some complexity and I believe it's safe.

  • RtlCaptureStackBackTrace is universally available.
    • It might not have been when this was originally implemented, but it's now documented as "Target Platform: Universal", and this aligns with its actual declaration.
  • Move GUID into Concurrency::details within #if defined(_CRT_APP) || defined(UNDOCKED_WINDOWS_UCRT).
    • It's static, so there's no ABI impact.
  • We don't need <mutex> - only <functional> for std::function and <stdexcept> for std::runtime_error.
  • Drop "ASYNC TODO" comment.
    • We're never going to change this legacy behavior.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Mar 4, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 4, 2024 02:17
@github-actions github-actions bot added this to Initial Review in Code Reviews Mar 4, 2024
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Mar 4, 2024
@StephanTLavavej StephanTLavavej self-assigned this Mar 6, 2024
@StephanTLavavej
Copy link
Member Author

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0407db6 into microsoft:main Mar 8, 2024
37 checks passed
Code Reviews automation moved this from Final Review to Done Mar 8, 2024
@StephanTLavavej StephanTLavavej deleted the cleanups-7-people-tasks branch March 8, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant