Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download_unicode_data_files.py: Select latest or a specific version #4469

Merged

Conversation

StephanTLavavej
Copy link
Member

Followup to #4435, addressing @tahonermann's #4435 (comment).

Usage examples:

D:\GitHub\STL\tools\unicode_properties_parse>python download_unicode_data_files.py
Usage: python download_unicode_data_files.py [latest|<VERSION LIKE 15.0.0>]

D:\GitHub\STL\tools\unicode_properties_parse>python download_unicode_data_files.py x y
Usage: python download_unicode_data_files.py [latest|<VERSION LIKE 15.0.0>]

D:\GitHub\STL\tools\unicode_properties_parse>python download_unicode_data_files.py latest
   Base URL: https://unicode.org/Public/UCD/latest/
Downloading: https://unicode.org/Public/UCD/latest/ucd/DerivedCoreProperties.txt
Downloading: https://unicode.org/Public/UCD/latest/ucd/extracted/DerivedGeneralCategory.txt
Downloading: https://unicode.org/Public/UCD/latest/ucd/EastAsianWidth.txt
Downloading: https://unicode.org/Public/UCD/latest/ucd/auxiliary/GraphemeBreakProperty.txt
Downloading: https://unicode.org/Public/UCD/latest/ucd/auxiliary/GraphemeBreakTest.txt
Downloading: https://unicode.org/Public/UCD/latest/ucd/emoji/emoji-data.txt

D:\GitHub\STL\tools\unicode_properties_parse>dir *.txt
[...]
03/10/2024  05:30 PM         1,072,686 DerivedCoreProperties.txt
03/10/2024  05:30 PM           268,498 DerivedGeneralCategory.txt
03/10/2024  05:30 PM           194,188 EastAsianWidth.txt
03/10/2024  05:30 PM           111,505 emoji-data.txt
03/10/2024  05:30 PM            96,863 GraphemeBreakProperty.txt
03/10/2024  05:30 PM           188,211 GraphemeBreakTest.txt
               6 File(s)      1,931,951 bytes
[...]

D:\GitHub\STL\tools\unicode_properties_parse>python download_unicode_data_files.py 15.0.0
   Base URL: https://unicode.org/Public/15.0.0/
Downloading: https://unicode.org/Public/15.0.0/ucd/DerivedCoreProperties.txt
Downloading: https://unicode.org/Public/15.0.0/ucd/extracted/DerivedGeneralCategory.txt
Downloading: https://unicode.org/Public/15.0.0/ucd/EastAsianWidth.txt
Downloading: https://unicode.org/Public/15.0.0/ucd/auxiliary/GraphemeBreakProperty.txt
Downloading: https://unicode.org/Public/15.0.0/ucd/auxiliary/GraphemeBreakTest.txt
Downloading: https://unicode.org/Public/15.0.0/ucd/emoji/emoji-data.txt

D:\GitHub\STL\tools\unicode_properties_parse>dir *.txt
[...]
03/10/2024  05:30 PM         1,053,943 DerivedCoreProperties.txt
03/10/2024  05:30 PM           268,339 DerivedGeneralCategory.txt
03/10/2024  05:30 PM           186,337 EastAsianWidth.txt
03/10/2024  05:30 PM           111,505 emoji-data.txt
03/10/2024  05:30 PM            96,863 GraphemeBreakProperty.txt
03/10/2024  05:30 PM            83,691 GraphemeBreakTest.txt
               6 File(s)      1,800,678 bytes
[...]

D:\GitHub\STL\tools\unicode_properties_parse>python download_unicode_data_files.py peppermint
   Base URL: https://unicode.org/Public/peppermint/
Downloading: https://unicode.org/Public/peppermint/ucd/DerivedCoreProperties.txt
HTTP Error 404: Not Found

@StephanTLavavej StephanTLavavej added enhancement Something can be improved format C++20/23 format labels Mar 11, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 11, 2024 00:37
@github-actions github-actions bot added this to Initial Review in Code Reviews Mar 11, 2024
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Mar 11, 2024
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Mar 13, 2024
Copy link
Member

@barcharcraz barcharcraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall at some point hardcoding the specific version to download for reproducibility. Maybe we can make the version we used to ship VS the default?

@StephanTLavavej StephanTLavavej self-assigned this Mar 15, 2024
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 4ce6bb3 into microsoft:main Mar 16, 2024
37 checks passed
Code Reviews automation moved this from Ready To Merge to Done Mar 16, 2024
@StephanTLavavej StephanTLavavej deleted the download-vohaul-to-roger-jr branch March 16, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved format C++20/23 format
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants