Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize vector algorithms dispatch #4544

Merged
merged 27 commits into from Apr 9, 2024
Merged

Standardize vector algorithms dispatch #4544

merged 27 commits into from Apr 9, 2024

Conversation

AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev commented Mar 31, 2024 •
edited by StephanTLavavej

Resolves #4531

(See somewhat-related #4453.)

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner March 31, 2024 06:23
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Mar 31, 2024
@StephanTLavavej StephanTLavavej self-assigned this Mar 31, 2024
@StephanTLavavej
Verify _Nx == 8.
3f8857e
@StephanTLavavej
Update comments for renamed functions.
9693997
@StephanTLavavej
_Count_trivial => _Count_vectorized
2fe0e78
@StephanTLavavej
_Find_trivial => _Find_vectorized
e1634e7
@StephanTLavavej
_Find_first_of_trivial => _Find_first_of_vectorized
7e78deb
@StephanTLavavej
_Reverse_copy_trivially_copyable => _Reverse_copy_vectorized
e69d491
@StephanTLavavej
_Reverse_trivially_swappable => _Reverse_vectorized
e6c3897
@StephanTLavavej
_Mismatch => _Mismatch_vectorized
a4bf8cc
@StephanTLavavej
_Min_element => _Min_element_vectorized
6261ae2
@StephanTLavavej
_Max_element => _Max_element_vectorized
0a9b95f
@StephanTLavavej
_Minmax_element => _Minmax_element_vectorized
193c5a4
@StephanTLavavej
_Min( => _Min_vectorized( in <xutility>
b4bfc32
@StephanTLavavej
_Max( => _Max_vectorized( in <xutility>
8f0d5ae
@StephanTLavavej
_Minmax => _Minmax_vectorized
4d92cd5
@StephanTLavavej
Restore and rename __std_find_last_trivial => _Find_last_vectorized
f88de77
@StephanTLavavej
Handle _WIN64 in _Find_last_vectorized without recursing.
3326718
StephanTLavavej
StephanTLavavej reviewed Apr 3, 2024
View reviewed changes
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/src/vector_algorithms.cpp Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Apr 3, 2024
@StephanTLavavej StephanTLavavej mentioned this pull request Apr 7, 2024
Merged
@StephanTLavavej StephanTLavavej self-assigned this Apr 8, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d3c435b into microsoft:main Apr 9, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for this cleanup to improve maintainability! 🧹 🪄 😻

@AlexGuteniev AlexGuteniev deleted the dispatch branch April 10, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vector algorithms with element size dispatch: standardize dispatching?
2 participants
@AlexGuteniev @StephanTLavavej