<generator>: Cleanup P2502R2_generator/test.cpp
#4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Jun 14, 2024
| } | ||
|
|
||
| void deallocate(void* const vp, [[maybe_unused]] const std::size_t n) noexcept { | ||
| void deallocate(void* const vp, [[maybe_unused]] const size_t n) noexcept { |
There was a problem hiding this comment.
Pre-existing, not worth resetting testing: n is always unused and this should just be a nameless size_t.
StephanTLavavej
merged commit 62bb92b
into
microsoft:feature/generator
39 checks passed
|
Thanks, merged! 😻 🚀 Noticed a tiny pre-existing issue, can easily be cleaned up later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using namespace stdzip->co_zip,meow->co_upto)