Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a GitHub Workflow to automate Code Reviews Project #829

Merged
merged 3 commits into from
May 15, 2020
Merged

Use a GitHub Workflow to automate Code Reviews Project #829

merged 3 commits into from
May 15, 2020

Conversation

cbezault
Copy link
Contributor

No description provided.

@cbezault cbezault added the infrastructure Related to repository automation label May 13, 2020
@CaseyCarter
Copy link
Member

I find it incredibly amusing that this PR is not associated with the Code Review project =)

@cbezault cbezault force-pushed the project-automation branch 2 times, most recently from 32ab427 to 78f5d8e Compare May 13, 2020 15:50
@cbezault cbezault added this to New in Code Reviews via automation May 13, 2020
@cbezault
Copy link
Contributor Author

cbezault commented May 13, 2020 •
edited

It's odd, in my own Repo the action appeared in my PR where here it doesn't. cbezault#7

Edit: Though I guess that's desirable.

@cbezault cbezault changed the title Try out a GH action Use a GitHub action to move new and reopened PRs into the New column May 13, 2020
@cbezault cbezault changed the title Use a GitHub action to move new and reopened PRs into the New column Use a GitHub action to automate PR Review Project May 13, 2020
@cbezault cbezault changed the title Use a GitHub action to automate PR Review Project Use a GitHub Workflow to automate PR Review Project May 13, 2020
@cbezault cbezault changed the title Use a GitHub Workflow to automate PR Review Project Use a GitHub Workflow to automate Code Reviews Project May 13, 2020
@cbezault
Copy link
Contributor Author

Phew, that was a lot of title editing.

@cbezault cbezault marked this pull request as ready for review May 13, 2020 16:29
@cbezault cbezault requested a review from a team as a code owner May 13, 2020 16:29
@CaseyCarter
Copy link
Member

Phew, that was a lot of title editing.

Perhaps we need a Github workflow to automate fiddling with the title?

@cbezault
Copy link
Contributor Author

One thing that isn't obvious from this PR is that I added a secret to this repo. I used a PAT associated with my account with the following permissions: public_repo, repo:status, repo_deployment, workflow, write:repo_hook.

I could probably switch it out for one with no hook or deployment permissions if people feel strongly about it.

@CaseyCarter CaseyCarter moved this from New to Ready For Initial Review in Code Reviews May 13, 2020
StephanTLavavej
StephanTLavavej requested changes May 14, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you! 😸

.github/workflows/new-pr-triage.yml Outdated Show resolved Hide resolved
.github/workflows/new-pr-triage.yml Show resolved Hide resolved
Code Reviews automation moved this from Ready For Initial Review to Work In Progress May 14, 2020
@cbezault @StephanTLavavej
Update .github/workflows/new-pr-triage.yml
d3df41e 
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@cbezault
Copy link
Contributor Author

Okay I changed the token to be public_repo, repo:status, workflow.

@cbezault cbezault moved this from Work In Progress to Ready For Initial Review in Code Reviews May 14, 2020
@StephanTLavavej StephanTLavavej moved this from Ready For Initial Review to Ready To Merge in Code Reviews May 15, 2020
@cbezault cbezault merged commit ed2ba34 into microsoft:master May 15, 2020
Code Reviews automation moved this from Ready To Merge to Done May 15, 2020
@StephanTLavavej StephanTLavavej mentioned this pull request May 16, 2020
Closed
StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request May 18, 2020
@StephanTLavavej
Fix microsoft#842 "GitHub: Workflow automation is failing".
9c3b008 
Revert "Use a GitHub Workflow to automate Code Reviews Project (microsoft#829)"

This reverts commit ed2ba34.
@StephanTLavavej StephanTLavavej mentioned this pull request May 18, 2020
Merged
StephanTLavavej added a commit that referenced this pull request May 19, 2020
@StephanTLavavej
Fix #842 "GitHub: Workflow automation is failing". (#847)
809a908 
Revert "Use a GitHub Workflow to automate Code Reviews Project (#829)"

This reverts commit ed2ba34.
@StephanTLavavej StephanTLavavej mentioned this pull request Jul 1, 2020
Closed
@sam20908 sam20908 mentioned this pull request Feb 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
infrastructure Related to repository automation
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cbezault @CaseyCarter @StephanTLavavej