Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing positional parameter and ensure parent directory for file copy ops #180

Merged
merged 2 commits into from
May 12, 2023

Conversation

arudell
Copy link
Member

@arudell arudell commented May 5, 2023

Description

  • Fixed a missing positional parameter for setting the settings.xml read-only:$false
  • Added defensive coding for file copy operations to ensure parent directory exists

Change type

  • Bug fix (non-breaking change)
  • Code style update (formatting, local variables)
  • New Feature (non-breaking change that adds new functionality without impacting existing)
  • Breaking change (fix or feature that may cause functionality impact)
  • Other

Checklist:

  • My code follows the style and contribution guidelines of this project.
  • I have tested and validated my code changes.

@arudell arudell requested a review from a team as a code owner May 5, 2023 15:10
@arudell arudell enabled auto-merge May 5, 2023 15:10
@arudell arudell disabled auto-merge May 5, 2023 16:05
@arudell arudell changed the title Fix missing positional parameter Fix missing positional parameter and ensure parent directory for file copy ops May 5, 2023
@arudell arudell enabled auto-merge May 11, 2023 18:07
@arudell arudell disabled auto-merge May 12, 2023 13:42
@arudell arudell merged commit be0f195 into main May 12, 2023
4 checks passed
@arudell arudell deleted the user/arudell/fix-positional-param branch May 12, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants