[Question / Suggestion] Potential bug in the sample_labeled_unlabeled_data.

[bhoo-git]

Bug

algorithm = get_algorithm(config, get_net_builder(config.net, from_name=False), tb_log=None, logger=None)

Running the following cell in step 2 of the Beginner_Example.ipynb notebook returns the following error:

TypeError: unsupported operand type(s) for %: 'NoneType' and 'int'. Here is a screenshot of the actual error message.

I believe this is because of the if statement in line 83 of the sample_labeled_unlabeled_data function in semilearn/datasets/utils.py.

The default value for the variable ulb_num_labels is None (Nonetype), but the second half of the if statement returns True because None != "None" is true due to the string-NoneType type difference.

I found that this issue can be resolved by breaking the two if statements into separate lines as below:

Reproduce the Bug

Python version: 3.7.16
Dependencies: installed using pip install -r requirements.txt after cloning the github repo.

Error Messages and Logs

Provided above.

[Hhhhhhao]

Thanks for reporting this bug.
Would simply replace the or operation with and operation resolve the problem?
Or more strictly, we can add constraints in arguments to prevent the ulb_num_labels to be string type.

[Hhhhhhao]

Fixed in PR #135

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions]

This issue was closed because it has been stalled for 5 days with no activity.