This repository has been archived by the owner on Feb 21, 2020. It is now read-only.
Fixing deployment scripts, bug and CI badge. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintenance/fix deployment scripts
Maintenance/fix cityhotel and naming
Added CI status badge.
eiximenis
reviewed
May 6, 2019
Source/setup/02-deploy-apis.sh
Outdated
| @@ -53,7 +53,8 @@ while [ "$1" != "" ]; do | |||
| -d | --dns) shift | |||
| dns=$1 | |||
| ;; | |||
| --httpRouting) httpRouting=1 | |||
| --httpRouting) shift | |||
There was a problem hiding this comment.
I think that the "shift" in --httRouting is not correct: switch parameters can't have a "shift". If they do, next parameter name will be swallowed resulting in parameter errors.
Please @ivilches can review and fix that?
There was a problem hiding this comment.
You're right! Fixed with the commit below.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Powershell and bash deployment scripts.
Fixed bug with relationship between cities and hotels.
Added CI status badge.