Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose custom queries and/or the report queries in SQL Nexus so users can customize their data mining #239

Closed
PiJoCoder opened this issue Jun 28, 2023 · 9 comments
Assignees
Labels
wave 3 - complete consider this issue for next wave of fixes

Comments

@PiJoCoder
Copy link
Collaborator

PiJoCoder commented Jun 28, 2023

  1. Perhaps put a link to https://github.com/microsoft/SqlNexus/wiki/Reports-via-SQL-Queries on the main page report when SQL Nexus launches
  2. Expose the query text for the report in each query. We can do this by creating TextBox in every report and displaying the =DataSets!DataSet1.CommandText where DataSet1 is the name of the data set where the query lives. We can make the text hidden by default but visible by toggling some control (see Database Configuration and Properties report for an example)
@PiJoCoder PiJoCoder added the wave 3 - complete consider this issue for next wave of fixes label Jun 28, 2023
@PiJoCoder
Copy link
Collaborator Author

@hacitandogan, would you like to think about this one next. The request here is to expose the actual query behind the report in case people want to use it for direct analysis in SSMS. I can demo if you'd like

@hacitandogan hacitandogan self-assigned this Sep 13, 2023
@hacitandogan
Copy link
Contributor

@PiJoCoder , sure I will check this one and ping you for the demo and sync.

@PiJoCoder
Copy link
Collaborator Author

@PiJoCoder , sure I will check this one and ping you for the demo and sync.

You can use logic similar to this (in server configuration report), where the text of the query is not exposed at first, but we can have some toggle +/- to show it

image

@hacitandogan
Copy link
Contributor

@PiJoCoder

I did a sample on one of the reports to test this.

This is server configuration report , which has multiple datasets;

Hidden:
image

Visible:
image

Tried to keep it plain and simple but should we highlight that more or is this good ?
Once we clarify how it should look , my plan is to use same approach on the other reports as well.

@PiJoCoder
Copy link
Collaborator Author

@PiJoCoder

I did a sample on one of the reports to test this.

This is server configuration report , which has multiple datasets;

Hidden: image

Visible: image

Tried to keep it plain and simple but should we highlight that more or is this good ? Once we clarify how it should look , my plan is to use same approach on the other reports as well.

I agree with you that plain and simple is good. I don't think we need to go fancy on this. One thing that I image is to add this at the bottom of reports, away from other report data so people don't get confused. Is that how you image it too?

hacitandogan added a commit to hacitandogan/SqlNexus that referenced this issue Oct 6, 2023
@hacitandogan
Copy link
Contributor

@PiJoCoder , I sent a PR for one report only so you can also see and test this. If we are OK with this , I can implement the same for all reports.

@PiJoCoder
Copy link
Collaborator Author

@PiJoCoder , I sent a PR for one report only so you can also see and test this. If we are OK with this , I can implement the same for all reports.

Thank you! I'll test and let you know

@PiJoCoder
Copy link
Collaborator Author

@PiJoCoder , I sent a PR for one report only so you can also see and test this. If we are OK with this , I can implement the same for all reports.

Looks great, @hacitandogan! Let's proceed with it. Thank you

hacitandogan added a commit to hacitandogan/SqlNexus that referenced this issue Oct 11, 2023
-this is completed for all the reports in the list without checking if the report is actually in use or not.
-tested with the sample data and did not see any issues
-exception is ReadTrace reports, we dont have the rdls for them and we inherit / borrow them from RML  , not sure if we can do anything for them.
PiJoCoder added a commit that referenced this issue Oct 18, 2023
PR for review for #239 - Expose custom queries and/or the report queries
@hacitandogan
Copy link
Contributor

PR merged , closing this item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wave 3 - complete consider this issue for next wave of fixes
Projects
None yet
Development

No branches or pull requests

2 participants