Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Name and version information fields exists on the header of some reports but it is always empty. #263

Closed
hacitandogan opened this issue Nov 8, 2023 · 0 comments
Closed

Server Name and version information fields exists on the header of some reports but it is always empty. #263

hacitandogan opened this issue Nov 8, 2023 · 0 comments
Assignees
@hacitandogan
Labels
wave 3 - complete consider this issue for next wave of fixes

Comments

@hacitandogan
Copy link
Contributor

image

Noticed this while working on an another issue, this is related to the data we fill into the dbo.tbl_SCRIPT_ENVIRONMENT_DETAILS table.
Report datasets are using different where clauses then the current data.
Most likely we changed the source of this data / script where we imported.

Modifying report dataset queries with the new where clause is the fix.
Since I am currently touching all reports, I will modify these as well.

image
@hacitandogan hacitandogan self-assigned this Nov 8, 2023
@hacitandogan hacitandogan added the wave 3 - complete consider this issue for next wave of fixes label Nov 8, 2023
hacitandogan added a commit to hacitandogan/SqlNexus that referenced this issue Nov 9, 2023
@hacitandogan
microsoft#61 script fixes and microsoft#263 dataset fixes
9b43b2d 
+part of microsoft#61 tested the scripts and reports , fixed multiple casing issues.
+fixed all the issues I encountered during my test. (tested this agains a CS instance and CI instance)
+this is now ready for further tests, will send a PR so other team members can also test and feedback for any issue I am missing
@hacitandogan hacitandogan mentioned this issue Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacitandogan hacitandogan

Labels
wave 3 - complete consider this issue for next wave of fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PiJoCoder @hacitandogan