-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve use of Write-Log and exceptions #97
Improve use of Write-Log and exceptions #97
Commits on Jan 23, 2018
-
Add -Exception parameter to Write-Log. Still need documentation and p…
…roper support of pipelining.
Daniel Belcher committedJan 23, 2018 Configuration menu - View commit details
-
Copy full SHA for 90fba07 - Browse repository at this point
Copy the full SHA 90fba07View commit details -
- Add the -Exception parameter to Write-Log.
This optional parameter will enable easier logging of exception information. - Implement pipeline support for -Message parameter This parameter always accepted pipeline input but didn't follow existing PoSh paradigms for pipelining. Note that there is no performance benefit to pipelining, but the option is there. - Add Write-LogHelper. This cmdlet is not intended to be used by itself, but instead should support Write-Log. The cmdlet performs the actual act of writing to screen/log.
Daniel Belcher committedJan 23, 2018 Configuration menu - View commit details
-
Copy full SHA for e6070d7 - Browse repository at this point
Copy the full SHA e6070d7View commit details -
- Modify existing calls to Write-Log to take advantage of the new -Ex…
…ception parameter.
Daniel Belcher committedJan 23, 2018 Configuration menu - View commit details
-
Copy full SHA for 68e4b2c - Browse repository at this point
Copy the full SHA 68e4b2cView commit details
Commits on Jan 24, 2018
-
- Move the logic of Write-LogHelper back into Write-Log.
While it was nice to break things up, keeping the actual writing logic in Write-Log will lead to better exception information if the Write-* cmdlets fail, because the exception will show as originating from Write-Log (which makes sense), instead of Write-LogHelper (which makes less sense).
Daniel Belcher committedJan 24, 2018 Configuration menu - View commit details
-
Copy full SHA for 7434faa - Browse repository at this point
Copy the full SHA 7434faaView commit details -
- Minor change to exception logging in Telemetry.ps1
Daniel Belcher committedJan 24, 2018 Configuration menu - View commit details
-
Copy full SHA for 5499dcb - Browse repository at this point
Copy the full SHA 5499dcbView commit details -
- Revert changes to exception messages for complicated exceptiontypes…
… in Invoke-SBRestMethod, etc.
Daniel Belcher committedJan 24, 2018 Configuration menu - View commit details
-
Copy full SHA for e4f4aeb - Browse repository at this point
Copy the full SHA e4f4aebView commit details
Commits on Jan 26, 2018
-
- Rewrite existing uses of Write-Log that are joining the message con…
…tents.
Daniel Belcher committedJan 26, 2018 Configuration menu - View commit details
-
Copy full SHA for b158ca5 - Browse repository at this point
Copy the full SHA b158ca5View commit details
Commits on Jan 30, 2018
-
- Use explicit -Message parameer name with Write-Log
This commit replaces all (most?) instances of using Write-Log with implicit -Message parameter. Modified lines were found with the following regex replacement: Find : Write-Log\s([^-]) Replace: Write-Log -Message $1
Daniel Belcher committedJan 30, 2018 Configuration menu - View commit details
-
Copy full SHA for 9732b47 - Browse repository at this point
Copy the full SHA 9732b47View commit details -
Daniel Belcher committed
Jan 30, 2018 Configuration menu - View commit details
-
Copy full SHA for 79f2610 - Browse repository at this point
Copy the full SHA 79f2610View commit details