Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve use of Write-Log and exceptions #97

Merged
merged 9 commits into from
Jan 30, 2018
Merged

Improve use of Write-Log and exceptions #97

merged 9 commits into from
Jan 30, 2018

Commits on Jan 23, 2018

  1. Add -Exception parameter to Write-Log. Still need documentation and p…

    …roper support of pipelining.
    Daniel Belcher committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    90fba07 View commit details
    Browse the repository at this point in the history
  2. - Add the -Exception parameter to Write-Log.

      This optional parameter will enable easier logging of exception information.
    
    - Implement pipeline support for -Message parameter
      This parameter always accepted pipeline input but didn't follow existing PoSh paradigms
      for pipelining. Note that there is no performance benefit to pipelining, but the option is there.
    
    - Add Write-LogHelper.
      This cmdlet is not intended to be used by itself, but instead should support Write-Log. The cmdlet
      performs the actual act of writing to screen/log.
    Daniel Belcher committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    e6070d7 View commit details
    Browse the repository at this point in the history
  3. - Modify existing calls to Write-Log to take advantage of the new -Ex…

    …ception parameter.
    Daniel Belcher committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    68e4b2c View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. - Move the logic of Write-LogHelper back into Write-Log.

      While it was nice to break things up, keeping the actual writing logic in Write-Log will lead
      to better exception information if the Write-* cmdlets fail, because the exception will show
      as originating from Write-Log (which makes sense), instead of Write-LogHelper (which makes less sense).
    Daniel Belcher committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    7434faa View commit details
    Browse the repository at this point in the history
  2. - Minor change to exception logging in Telemetry.ps1

    Daniel Belcher committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    5499dcb View commit details
    Browse the repository at this point in the history
  3. - Revert changes to exception messages for complicated exceptiontypes…

    … in Invoke-SBRestMethod, etc.
    Daniel Belcher committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    e4f4aeb View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2018

  1. - Rewrite existing uses of Write-Log that are joining the message con…

    …tents.
    Daniel Belcher committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    b158ca5 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2018

  1. - Use explicit -Message parameer name with Write-Log

    This commit replaces all (most?) instances of using Write-Log with implicit -Message parameter.
    Modified lines were found with the following regex replacement:
    
        Find   : Write-Log\s([^-])
    	Replace: Write-Log -Message $1
    Daniel Belcher committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    9732b47 View commit details
    Browse the repository at this point in the history
  2. Bump module version to 1.14.0

    Daniel Belcher committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    79f2610 View commit details
    Browse the repository at this point in the history