Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probability values still incorrect when requesting raw and probability columns #666

Closed
imatiach-msft opened this issue Aug 25, 2019 · 1 comment
Assignees
Labels
area/lightgbm bug high priority high priority issues must be fixed as soon as possible

Comments

@imatiach-msft
Copy link
Contributor

imatiach-msft commented Aug 25, 2019

Describe the bug
There is a caching bug in the new native code which causes the probability values to be calculated as raw when requesting both columns to be computed.

To Reproduce
Print out the results of lightgbm model, see that the probabilities are invalid, eg not between 0 and 1

Expected behavior
Probabilities should correspond to output label and raw predictions transformed from log odds.

Info (please complete the following information):

  • MMLSpark Version: v0.18.1
  • Spark Version Any
  • Spark Platform Any
Please post the stacktrace here if applicable

If the bug pertains to a specific feature please tag the appropriate CODEOWNER for better visibility

Additional context
See lightgbm PR here:
microsoft/LightGBM#2356
a new maven dependency will need to be published once it is in.

See related issue, but fixed in correct way as long as user only asks for one column:
#568

@imatiach-msft imatiach-msft self-assigned this Aug 25, 2019
@imatiach-msft imatiach-msft added bug high priority high priority issues must be fixed as soon as possible area/lightgbm labels Aug 25, 2019
@imatiach-msft
Copy link
Contributor Author

fixed in master with #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lightgbm bug high priority high priority issues must be fixed as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant