[java][mmlspark] Fix cached predictor causing bad values for predicted probabilities #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adding @eisber |
imatiach-msft
commented
Aug 25, 2019
src/c_api.cpp
Outdated
| int64_t single_row_num_pred_in_one_row_; | ||
| std::unique_ptr<Predictor> single_row_predictor_[PREDICTOR_TYPES]; | ||
| bool single_row_predictor_pred_early_stop[PREDICTOR_TYPES]; | ||
| int single_row_predictor_pred_early_stop_freq[PREDICTOR_TYPES]; |
There was a problem hiding this comment.
just to confirm, will these arrays be freed correctly with the class on the heap once class is deleted?
There was a problem hiding this comment.
those are fixed size arrays and they'll be deallocated directly.
I'd suggest to use create a
- new class containing the relevant subset (unique_ptr, bool, int)
- implement operator== (const Config&) and operator=(const Config&)
- would make the assignment and comparison a bit more readable.
There was a problem hiding this comment.
@eisber I already created a new class containing those variables, can you take a look at the latest commit?
There was a problem hiding this comment.
also for comparison "implement operator== (const Config&) and operator=(const Config&)" I created a method since I needed to compare other variables besides the Config
imatiach-msft
commented
Aug 25, 2019
guolinke
reviewed
Aug 27, 2019
guolinke
reviewed
Aug 27, 2019
|
@imatiach-msft Thanks! much cleaner now. |
StrikerRUS
reviewed
Aug 28, 2019
imatiach-msft
changed the title
guolinke
approved these changes
Aug 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mmlspark, the predictied probabilities column was appearing the same as raw predicted values when both columns were computed from the model. This is due to a caching bug in the native code logic that was recently added. I added an array of predictors, one for each type, to fix the caching bug - and also added some additional checks in case the cached predictor needs to be reinitialized (not used by mmlspark directly).